Add proxy tests for the AppSync service #120
Conversation
Add comprehensive proxy tests for AWS AppSync covering: - GraphQL API CRUD operations - API key management - Schema creation and introspection - Data source operations - Read-only proxy mode - Operations-based filtering Uses fixture-based cleanup to ensure no AWS resources are left behind. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add retry around put_record call as Kinesis streams may need a brief moment after reporting ACTIVE status before they can accept writes. Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Tests look good 🙌
One interesting observation about appsync operations
There are (at least) two operations that would incorrectly identified as WRITE requests by our logic :
Not sure if we want modify the aws_proxy.server.aws_request_forwarder.AwsProxyHandler._is_read_request in this PR to have better read-only support of the service.
I think It would be great if the agent would be able to "catch" these and improve the read-only support in general, maybe we could re-iterate on the AGENTS.md instructions to make it happen?
Add EvaluateCode and EvaluateMappingTemplate to the list of read-only operations for AppSync, and document guidelines for identifying non-standard read-only operations in AGENTS.md. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Test that EvaluateCode and EvaluateMappingTemplate are correctly identified as read operations and work with read_only proxy config. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
That's a great catch @nik-localstack ! 🙌 I've updated the PR (again, with help from Claude code, based on your review feedback): slightly adjusted the logic, added a note in the README, and also covered it with a small test. 👍 |
Add comprehensive proxy tests for AWS AppSync.
Note 🤖 : Tests have been generated via an AI agent (Claude Code).
Changes:
Uses fixture-based cleanup to ensure no AWS resources are left behind.